Add validator for hardware/targets.json and run it before builds - #236
Merged
Conversation
Validates vendor and device structure, platform and upload_methods values, and cross-checks each firmware against targets/*.ini: the _via_UART environment must exist and the platform resolved from its extends chain must match the device's declared platform. Environments not referenced by any target are reported as warnings, and --warn promotes warnings to errors. The build workflow gates the target matrix on validation, so nothing compiles when targets.json is invalid.
pkendall64
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validates vendor and device structure, platform and upload_methods values, and cross-checks each firmware against targets/*.ini: the _via_UART environment must exist and the platform resolved from its extends chain must match the device's declared platform. Environments not referenced by any target are reported as warnings, and --warn promotes warnings to errors. The build workflow gates the target matrix on validation, so nothing compiles when targets.json is invalid.